Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IWYU pragma export in catch_all.hpp #2741

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

vient
Copy link

@vient vient commented Sep 9, 2023

Description

Fix IWYU warnings when using catch_all.hpp

GitHub Issues

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #2741 (57b52f2) into devel (47a2c96) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #2741      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.01%     
==========================================
  Files         190      190              
  Lines        7855     7855              
==========================================
- Hits         7176     7175       -1     
- Misses        679      680       +1     

@horenmar
Copy link
Member

horenmar commented Sep 9, 2023

  1. You want pragma begin_exports/end_exports
  2. Won't this cause issues where IWYU will try to replace includes of other headers with catch_all.hpp?

@vient
Copy link
Author

vient commented Sep 9, 2023

  1. I'm actually using clangd, they only support most basic pragmas :( https://clangd.llvm.org/guides/include-cleaner#iwyu-pragmas
  2. I checked that clangd does not do this, not sure about original IWYU tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants